Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _doc_count to Service metrics #9143

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Add _doc_count to Service metrics #9143

merged 2 commits into from
Sep 20, 2022

Conversation

Mpdreamz
Copy link
Member

This to ensure proper bucket counts as discovered on

elastic/kibana#140868

Motivation/summary

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@Mpdreamz
Add _doc_count to Service metrics
37514d9 
This to ensure proper bucket counts as discovered on

elastic/kibana#140868
@Mpdreamz Mpdreamz mentioned this pull request Sep 20, 2022
Merged
1 task
@mergify

This comment was marked as outdated.

Sign in to view
@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Sep 20, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Sep 20, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-20T13:50:53.247+0000

  • Duration: 27 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 148
Skipped 0
Total 148

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

apmmachine commented Sep 20, 2022 •
edited
Loading

📚 Go benchmark report

Diff with the main branch

name                                                                                              old time/op    new time/op    delta
pkg:github.com/elastic/apm-server/internal/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/beater/request goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/processor/stream goos:linux goarch:amd64
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/errors_rum.ndjson-12                    7.50µs ± 4%    6.91µs ± 3%   -7.84%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/events.ndjson-12                        44.2µs ± 9%    52.0µs ±12%  +17.60%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/metricsets.ndjson-12                    14.7µs ± 4%    15.6µs ± 5%   +6.23%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/transactions_spans_rum_2.ndjson-12      5.25µs ± 4%    5.05µs ± 3%   -3.92%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/events.ndjson-12                        27.5µs ± 4%    30.1µs ± 5%   +9.31%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/otel-bridge.ndjson-12                   3.96µs ± 1%    3.77µs ± 1%   -4.79%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/ratelimit.ndjson-12                     6.64µs ± 2%    6.16µs ± 1%   -7.26%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/span-links.ndjson-12                    1.60µs ± 1%    1.53µs ± 1%   -4.46%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/spans.ndjson-12                         11.4µs ± 0%    10.8µs ± 1%   -4.86%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions-huge_traces.ndjson-12      5.71µs ± 1%    5.48µs ± 1%   -4.03%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions.ndjson-12                  11.3µs ± 1%    10.9µs ± 1%   -3.75%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans.ndjson-12            11.3µs ± 1%    10.7µs ± 2%   -5.77%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans_rum.ndjson-12        2.06µs ± 1%    1.96µs ± 1%   -4.87%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans_rum_2.ndjson-12      1.99µs ± 1%    1.91µs ± 1%   -4.19%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/unknown-span-type.ndjson-12             7.48µs ± 2%    7.13µs ± 1%   -4.71%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors.ndjson-12                      7.68µs ± 2%    6.87µs ± 2%  -10.51%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors_2.ndjson-12                    7.07µs ± 2%    6.58µs ± 4%   -6.86%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors_rum.ndjson-12                  2.01µs ± 1%    1.94µs ± 1%   -3.51%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors_transaction_id.ndjson-12       5.60µs ± 1%    5.36µs ± 1%   -4.35%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/events.ndjson-12                      13.5µs ± 1%    13.0µs ± 1%   -4.27%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/heavy.ndjson-12                        522µs ± 4%     502µs ± 2%   -3.82%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-event-type.ndjson-12           817ns ± 2%     785ns ± 2%   -3.92%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-event.ndjson-12               3.43µs ± 0%    3.30µs ± 1%   -3.69%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-json-event.ndjson-12          1.11µs ± 1%    1.07µs ± 2%   -3.37%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-json-metadata.ndjson-12       1.95µs ± 1%    1.86µs ± 1%   -4.63%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-metadata-2.ndjson-12           501ns ± 1%     480ns ± 2%   -4.31%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-metadata.ndjson-12             506ns ± 1%     486ns ± 1%   -3.92%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/logs.ndjson-12                        1.92µs ± 2%    1.84µs ± 4%   -4.34%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metadata-null-values.ndjson-12         791ns ± 5%     760ns ± 1%   -3.86%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metadata.ndjson-12                    1.30µs ± 2%    1.24µs ± 1%   -4.19%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metricsets.ndjson-12                  4.50µs ± 1%    4.33µs ± 1%   -3.90%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/minimal-service.ndjson-12              980ns ± 1%     963ns ± 1%   -1.73%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/minimal.ndjson-12                     2.02µs ± 1%    1.94µs ± 2%   -3.85%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/optional-timestamps.ndjson-12         1.49µs ± 2%    1.44µs ± 1%   -3.60%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/otel-bridge.ndjson-12                 3.25µs ± 1%    3.14µs ± 2%   -3.37%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/ratelimit.ndjson-12                   5.81µs ± 4%    5.56µs ± 2%   -4.30%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/span-links.ndjson-12                  1.22µs ± 2%    1.17µs ± 1%   -4.14%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/spans.ndjson-12                       9.81µs ± 2%    9.31µs ± 3%   -5.08%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions-huge_traces.ndjson-12    4.75µs ± 1%    4.56µs ± 1%   -4.19%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions.ndjson-12                9.63µs ± 2%    9.33µs ± 2%   -3.15%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions_spans_rum.ndjson-12      1.64µs ± 2%    1.56µs ± 1%   -5.11%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions_spans_rum_2.ndjson-12    1.56µs ± 1%    1.50µs ± 1%   -3.91%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/unknown-span-type.ndjson-12           6.30µs ± 2%    6.09µs ± 2%   -3.34%  (p=0.008 n=5+5)
ReadBatch/minimal.ndjson-12                                                                         20.1µs ±18%    27.1µs ±17%  +35.20%  (p=0.016 n=5+5)
pkg:github.com/elastic/apm-server/internal/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64

name                                                                                              old alloc/op   new alloc/op   delta
pkg:github.com/elastic/apm-server/internal/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/beater/request goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/processor/stream goos:linux goarch:amd64
BackendProcessor/errors_rum.ndjson-12                                                               7.89kB ± 1%    7.82kB ± 1%   -0.82%  (p=0.024 n=5+5)
BackendProcessor/errors_transaction_id.ndjson-12                                                    18.9kB ± 0%    19.2kB ± 1%   +1.41%  (p=0.016 n=4+5)
BackendProcessor/spans.ndjson-12                                                                    29.3kB ± 1%    28.9kB ± 1%   -1.47%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/heavy.ndjson-12                          851kB ± 0%     858kB ± 1%   +0.86%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/logs.ndjson-12                          9.20kB ± 1%    9.33kB ± 1%   +1.33%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/transactions_spans_rum_2.ndjson-12      6.13kB ± 1%    6.07kB ± 1%   -1.03%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/minimal.ndjson-12                     6.10kB ± 1%    5.97kB ± 1%   -2.23%  (p=0.008 n=5+5)
ReadBatch/transactions_spans_rum_2.ndjson-12                                                        4.59kB ± 0%    4.59kB ± 0%   +0.05%  (p=0.040 n=5+5)
pkg:github.com/elastic/apm-server/internal/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64
ReadEvents/json_codec/199_events-12                                                                 1.10MB ± 0%    1.10MB ± 0%   +0.05%  (p=0.024 n=5+5)
ReadEvents/json_codec/1000_events-12                                                                3.47MB ± 0%    3.44MB ± 0%   -0.79%  (p=0.016 n=4+5)
ReadEvents/nop_codec/10_events-12                                                                   25.7kB ± 0%    25.7kB ± 0%   +0.12%  (p=0.016 n=5+5)
ReadEvents/nop_codec/1000_events-12                                                                 2.18MB ± 0%    2.19MB ± 0%   +0.40%  (p=0.016 n=5+5)

name                                                                                              old allocs/op  new allocs/op  delta
pkg:github.com/elastic/apm-server/internal/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/beater/request goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/processor/stream goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64

name                                                                                              old speed      new speed      delta
pkg:github.com/elastic/apm-server/internal/processor/stream goos:linux goarch:amd64
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/errors_rum.ndjson-12                   253MB/s ± 4%   275MB/s ± 3%   +8.49%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/events.ndjson-12                       169MB/s ±10%   144MB/s ±11%  -14.55%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/metricsets.ndjson-12                   173MB/s ± 3%   163MB/s ± 5%   -5.81%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/transactions_spans_rum_2.ndjson-12     213MB/s ± 4%   221MB/s ± 3%   +4.06%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/events.ndjson-12                       270MB/s ± 4%   247MB/s ± 5%   -8.51%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/otel-bridge.ndjson-12                  475MB/s ± 1%   499MB/s ± 1%   +5.04%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/ratelimit.ndjson-12                    634MB/s ± 2%   684MB/s ± 1%   +7.82%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/span-links.ndjson-12                   425MB/s ± 1%   445MB/s ± 1%   +4.67%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/spans.ndjson-12                        706MB/s ± 0%   742MB/s ± 1%   +5.12%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions-huge_traces.ndjson-12     555MB/s ± 1%   578MB/s ± 1%   +4.20%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions.ndjson-12                 499MB/s ± 1%   518MB/s ± 1%   +3.89%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans.ndjson-12           513MB/s ± 1%   544MB/s ± 2%   +6.13%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans_rum.ndjson-12       561MB/s ± 1%   590MB/s ± 1%   +5.14%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans_rum_2.ndjson-12     561MB/s ± 1%   586MB/s ± 1%   +4.37%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/unknown-span-type.ndjson-12            442MB/s ± 2%   464MB/s ± 1%   +4.93%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors.ndjson-12                     826MB/s ± 2%   923MB/s ± 2%  +11.75%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors_2.ndjson-12                   667MB/s ± 2%   717MB/s ± 4%   +7.41%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors_rum.ndjson-12                 942MB/s ± 1%   976MB/s ± 1%   +3.63%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors_transaction_id.ndjson-12      682MB/s ± 1%   713MB/s ± 1%   +4.55%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/events.ndjson-12                     549MB/s ± 1%   574MB/s ± 1%   +4.46%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/heavy.ndjson-12                      765MB/s ± 4%   795MB/s ± 2%   +3.92%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-event-type.ndjson-12         478MB/s ± 2%   498MB/s ± 2%   +4.09%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-event.ndjson-12              223MB/s ± 0%   232MB/s ± 1%   +3.82%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-json-event.ndjson-12         529MB/s ± 1%   547MB/s ± 2%   +3.49%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-json-metadata.ndjson-12      229MB/s ± 1%   240MB/s ± 1%   +4.86%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-metadata-2.ndjson-12         870MB/s ± 1%   909MB/s ± 2%   +4.51%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-metadata.ndjson-12           882MB/s ± 1%   918MB/s ± 1%   +4.08%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/logs.ndjson-12                       690MB/s ± 2%   722MB/s ± 4%   +4.58%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metadata-null-values.ndjson-12       665MB/s ± 4%   692MB/s ± 1%   +3.96%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metadata.ndjson-12                   958MB/s ± 2%  1000MB/s ± 1%   +4.36%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metricsets.ndjson-12                 565MB/s ± 1%   588MB/s ± 1%   +4.06%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/minimal-service.ndjson-12            434MB/s ± 1%   441MB/s ± 1%   +1.76%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/minimal.ndjson-12                    511MB/s ± 1%   532MB/s ± 2%   +4.03%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/optional-timestamps.ndjson-12        687MB/s ± 2%   713MB/s ± 1%   +3.76%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/otel-bridge.ndjson-12                579MB/s ± 1%   599MB/s ± 2%   +3.50%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/ratelimit.ndjson-12                  725MB/s ± 4%   758MB/s ± 2%   +4.46%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/span-links.ndjson-12                 561MB/s ± 2%   585MB/s ± 1%   +4.33%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/spans.ndjson-12                      819MB/s ± 2%   863MB/s ± 3%   +5.35%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions-huge_traces.ndjson-12   667MB/s ± 1%   696MB/s ± 1%   +4.36%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions.ndjson-12               586MB/s ± 2%   605MB/s ± 2%   +3.25%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions_spans_rum.ndjson-12     703MB/s ± 2%   740MB/s ± 1%   +5.38%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions_spans_rum_2.ndjson-12   714MB/s ± 1%   743MB/s ± 1%   +4.06%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/unknown-span-type.ndjson-12          525MB/s ± 2%   543MB/s ± 2%   +3.47%  (p=0.008 n=5+5)
ReadBatch/minimal.ndjson-12                                                                       51.9MB/s ±16%  38.5MB/s ±16%  -25.86%  (p=0.016 n=5+5)

report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat

@simitt
Copy link
Contributor

simitt commented Sep 20, 2022

/test

kruskall
kruskall approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@kruskall kruskall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz Mpdreamz merged commit 8cf329e into elastic:main Sep 20, 2022
@Mpdreamz Mpdreamz deleted the fix/main/service-metrics-doc-count branch September 20, 2022 15:01
This was referenced Sep 21, 2022
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simitt simitt simitt approved these changes

@kruskall kruskall kruskall approved these changes

Assignees
No one assigned
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mpdreamz @apmmachine @simitt @kruskall